Join column must be defined with the same insertable and updatable attributes (HHH-17586)

Code generation uses the classes from ORM (hibernate-core) and so the problem is in ORM.

The code generation detects a many-to-many relationship and creates the annotations @ManyToMany and @JoinTable.

• [Tools] org.hibernate.tool.internal.export.java.EntityPOJOClass#generateCollectionAnnotation(Property, Metadata) uses Property#isUpdatable()

  • [ORM] org.hibernate.mapping.Property#isUpdatable()

    • [ORM] Forwards to org.hibernate.mapping.Value#hasAnyUpdatableColumns() (where the implementation is org.hibernate.mapping.Set implementing org.hibernate.mapping.Collection)

      • [ORM] org.hibernate.mapping.Collection#hasAnyUpdatableColumns() hardcodes the value to false while org.hibernate.mapping.Collection#hasAnyInsertableColumns() is hardcoded to true.
        This does not match the behaviour required by the new check.

But I will additionally create a Tools issue.

@SteGr this sounds like a code generation problem, not an ORM problem, so please open an issue on Hibernate Tools' Jira and link it to this one: https://hibernate.atlassian.net/browse/HBX. We can verify if something should be changed in ORM as well, but let’s take a look at Tools first.

According to this commit, this was once set to return true, but changed back to false because of some bug.

Sorry for the back and forth. I just realized that the class org.hibernate.mapping.Collection is part of ORM and not of Tools.

@Marco Belladelli Presumably the only solution here is to change hasAnyUpdatableColumns() returning false to true. Because if the new check introduced with https://hibernate.atlassian.net/browse/HHH-17334 is to ensure that insertable == updatable, and hasAnyInsertableColumns() is true here, then hasAnyUpdatableColumns() must also be true.