Settings build unnecessary in schemaupdate/schemavalidate

Description

the fix for causes a new Settings object to be built for each table mapping when doing a schema update or validate. this is unnecessary.

in some scenarios, it might be expensive to build a new settings object because it communicates with the database for metadata and it also creates a cache provider, which might be expensive to create for clustered caches.

to fix, buildSettings (lines 947 and 1069) should be pulled out of the while loop.

Activity

Show:

Max Rydahl AndersenNovember 17, 2006 at 8:39 PM

fixed in head and 3.2.

Removed the buildSettings() completly and used the "old" way of looking up in properties.

Max Rydahl AndersenNovember 17, 2006 at 8:30 PM

updated to explain severity ;(

Fixed

Details

Assignee

Reporter

Fix versions

Affects versions

Priority

Created November 17, 2006 at 8:20 PM
Updated November 17, 2006 at 8:39 PM
Resolved November 17, 2006 at 8:39 PM