Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

make constructor of DynamicMapEntityTuplizer public

Description

The constructor of DynamicMapEntityTuplizer should be public to enable the creation of DynamicMapEntityTuplizer subclasses.

Activity

Show:

Christian BeikovMarch 17, 2021 at 4:06 PM

Won't do as we removed EntityTuplizer in 6.0

Alvaro PedrazaJuly 19, 2018 at 2:33 AM
Edited

Can you explain how that dramatic change in 6 would affect this ticket? how can affect the migration guide?
Thanks in advance for your answer

Steve EbersoleJuly 17, 2018 at 1:20 PM

I'm not against making it extendable per-se. However:

  1. That almost always means much more than simply making a constructor public. A Class/contract needs to be designed with extensibility in mind, and this Class was not. E.g., if this is to be extended it makes sense to define #buildPropertyAccess as protected. Etc

  2. I'm a bit leery of the timing simply because all of this is going through such a dramatic change in 6 - I think we should be looking to minimize the "migration guide", not seek to grow it.

Alvaro PedrazaJuly 3, 2018 at 3:31 AM

Is subclassing for DynamicMapEntityTuplizer even desirable? I mean, it may be some reasonable arguments to make it package accesible in the first place.
I don't know why I'm not able to tag members, so can anybody reach out Steve Ebersole and/or Gavin King to ask about this class constructor?

Won't Do

Details

Assignee

Reporter

Components

Priority

Created February 28, 2008 at 4:56 PM
Updated March 17, 2021 at 4:06 PM
Resolved March 17, 2021 at 4:06 PM