Calling Query.iterator() executed queries and leaves preparedstatements open if not iterated to the end.

Description

I was wondering if this design point/flaw is still valid:

QueryLoader
http://kickjava.com/src/org/hibernate/loader/hql/QueryLoader.java.htm
Makes Iterator:
http://kickjava.com/src/org/hibernate/impl/IteratorImpl.java.htm

QueryLoader gives ResultSet and PreparedStatement to iterator.

Every time Qeury.iterator() is called, it executes queries. So, if you do not iterate code to the end it leaves PS, RS open. close()-method is only called if hasNext() is false. (postNext())

Commit does not close these since it does not have access to them .

This code leaves preparedstatement open and finally after 100-200 open preparedstatements hibernate crashes:

if(query.iterate().hasNext()) query.iterate().next();

I think this is a major design issue. Is this considered as bug or "it works like this, just iterate to the end and use proper SQL-queries"?

Whole iterator-logic needs redesign

Environment

Hibernate 3.1.2, Oracle 9.0.2.8

Assignee

Unassigned

Reporter

Jari Timonen

Fix versions

None

Labels

None

backPortable

None

Suitable for new contributors

None

Requires Release Note

None

Pull Request

None

backportDecision

None

Components

Affects versions

Priority

Major
Configure