Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Rename SchemaExport "drop" attribute

Description

The Ant SchemaExport task has an attribute "drop" which is very misleading. When drop="true" is used, SchemaExport will only drop tables and not export anything. The name seems to imply that drop="true" means SchemaExport will add "drop table" statements and with drop="false" it will not.

The attribute should be renamed to "onlyDrop" or something. I point this out because this cost me hours of development time and someone else in #hibernate IRC channel just reported running into the exact same problem.

Activity

GiliGApril 28, 2005 at 8:06 AM

That's fine, but their values should default to true so users get what they perceive is the correct behavior. Sorry, I know there is a lot of backwards compatibility issues here, but the current behavior is very confusing. If you can't rename the attribute name, changing the defaults might be a nice way to make everyone happy. <shrug> Food for thought.

Max Rydahl AndersenApril 28, 2005 at 8:00 AM

the new ant tasks has both drop and export flags which allows you to combine it to whatever setting you want.

GavinGApril 28, 2005 at 2:21 AM

sorry, this is ancient naming, can't change it now

Rejected

Details

Assignee

Reporter

Components

Priority

Created April 28, 2005 at 1:42 AM
Updated April 28, 2005 at 8:06 AM
Resolved April 28, 2005 at 2:21 AM