Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

in org.hibernate.mapping.PersistentClass some 2 performance issues can be fixed

Description

3 performance issues in org.hibernate.mapping.PersistentClass:

1. The mappedClass is loaded again and again calling ReflectHelper.classForName(className). The mapped class is not changed so it should be hold as member variable.

2. Method getProperty(String, Iterator) uses a MappingException which is ignored in getRecursiveProperty(String, Iterator). This makes the recursion more expensive than required.

3. Method getProperty calls StringHelper.root( propertyName ) for every property. Simply change the while in if do while.

A fix is provided as attachment.

Attachments

1

Activity

Show:

Brett MeyerAugust 19, 2013 at 7:52 PM

Thanks for the patch and PR!

Anton MarsdenAugust 6, 2013 at 11:11 AM

A pull request has been added for this: https://github.com/hibernate/hibernate-orm/pull/557

Fixed

Details

Assignee

Reporter

Original estimate

Time tracking

No time logged0.5h remaining

Fix versions

Priority

Created February 11, 2011 at 6:44 PM
Updated August 28, 2013 at 4:37 PM
Resolved August 19, 2013 at 7:52 PM