AuditJoinTable does not default to a concatenation of the primary table names, as stated in Doumentation

Description

The Documentation at http://docs.jboss.org/envers/api-new/org/hibernate/envers/AuditJoinTable.html states that the AuditJoinTable "defaults to a concatenation of the names of the primary table of the entity owning the association and of the primary table of the entity referenced by the association."

Instead, the default is the concatenation of the two entities' class names. The behavior described in the documentation is preferable to the actual behavior, since it's easy for two concatenated class names to result in an AuditJoinTable name over 30 characters, which Oracle does not support.

The relevant part of the code can be found in CollectionMetadataGenerator.java:272 in Hibernate 3.6.2:

return StringTools.getLastComponent(entityName) + "_" + StringTools.getLastComponent(MappingTools.getReferencedEntityName(value.getElement()));

I figured out how to make the second part of the concatenation use the proper table name (but I did not figure out how to also fix the first part yet):

return StringTools.getLastComponent(entityName) + "_" + value.getElement().getTable().getName();

Environment

Oracle

Activity

Show:
Brett Meyer
April 7, 2014, 5:42 PM

In an effort to clean up, in bulk, tickets that are most likely out of date, we're transitioning all ORM 3 tickets to an "Awaiting Test Case" state. Please see http://in.relation.to/Bloggers/HibernateORMJIRAPoliciesAndCleanUpTactics for more information.

If this is still a legitimate bug in ORM 4, please provide either a test case that reproduces it or enough detail (entities, mappings, snippets, etc.) to show that it still fails on 4. If nothing is received within 3 months or so, we'll be automatically closing them.

Thank you!

Brett Meyer
July 8, 2014, 3:11 PM

Bulk rejecting stale issues. If this is still a legitimate issue on ORM 4, feel free to comment and attach a test case. I'll address responses case-by-case. Thanks!

Assignee

Unassigned

Reporter

Robin G

Fix versions

None

Labels

None

backPortable

None

Suitable for new contributors

None

Requires Release Note

None

Pull Request

None

backportDecision

None

Affects versions

Priority

Minor
Configure