Exception on lock mode when setting lock mode NONE for named query
Description
Get the following stack trace:
Caused by: java.lang.IllegalStateException: Illegal attempt to set lock mode on a non-SELECT query at org.hibernate.jpa.spi.AbstractQueryImpl.setLockMode(AbstractQueryImpl.java:128) at org.hibernate.jpa.spi.AbstractEntityManagerImpl.applySavedSettings(AbstractEntityManagerImpl.java:858) at org.hibernate.jpa.spi.AbstractEntityManagerImpl.wrapAsJpaQuery(AbstractEntityManagerImpl.java:812) at org.hibernate.jpa.spi.AbstractEntityManagerImpl.createNamedJpqlQuery(AbstractEntityManagerImpl.java:806) at org.hibernate.jpa.spi.AbstractEntityManagerImpl.buildQueryFromName(AbstractEntityManagerImpl.java:785) at org.hibernate.jpa.spi.AbstractEntityManagerImpl.createNamedQuery(AbstractEntityManagerImpl.java:770) at com.sun.enterprise.container.common.impl.EntityManagerWrapper.createNamedQuery(EntityManagerWrapper.java:522) at no.evote.service.impl.TestServiceImpl.deleteTasks(TestServiceImpl.java:140)
It is unfortunately difficult to run our code in a "new" environment - we work on it.
What basically happens is that we work on upgrading from glassfish 3.1.2 to glassfish 4, and from hibernate 3.5.1 to hibernate 4.3.0.CR1.
We do some manual cleaning after running a test called ElectionEventServiceTest (found in admin-backend). A method in TestServiceImpl which does the following is called:
@Override public void deleteTasks(final UserData userData, final Long electionEventPk) { Query query = getEm().createNamedQuery("Task.deleteElectionEventPk").setParameter("electionEventPk", electionEventPk); query.executeUpdate(); }
where
@NamedQuery(name = "Task.deleteElectionEventPk", query = "delete from Task t where t.electionEvent.pk = :electionEventPk"),
(Task in admin-common).
The problem can be fixed by checking if the non-select query actually just tries to set lock mode to NONE which to me seems reasonable:
My local version of AbstractQueryImpl works fine..
AbstractQueryImpl:
public TypedQuery<X> setLockMode(javax.persistence.LockModeType lockModeType) { checkOpen( true );
if ( isNativeSqlQuery() ) { throw new IllegalStateException( "Illegal attempt to set lock mode on a native SQL query" ); }
if ( ! LockModeType.NONE.equals(lockModeType)) { if ( ! isSelectQuery() ) { throw new IllegalStateException( "Illegal attempt to set lock mode on a non-SELECT query" ); } } if ( ! canApplyAliasSpecificLockModeHints() ) { throw new IllegalStateException( "Not a JPAQL/Criteria query" ); }
Is there a workaround for this other than using a NamedNativeQuery? I'm need a NamedQuery so I can have an in clause parameter that takes a collection and last time I looked that was not supported in a NamedNativeQuery. Thanks!
Brett MeyerJanuary 9, 2014 at 7:57 PM
Thanks for the PR!
Robert DiFalcoJanuary 2, 2014 at 12:03 AM
Does this seem to any like a massive issue? Basically, I cannot run JPL update queries using NamedQuery. Unfortunately, it my case I cannot change to a NamedNativeQuery. Is there really no unit tests that would have caught this early in development? No unit test that does an update in a NamedQuery?
KoljaKDecember 4, 2013 at 10:32 AM
We found a workaround using NamedNativeQuery instead of NamedQuery
KoljaKDecember 3, 2013 at 10:22 AM
Hi, we have the same problem right now. We are using Postgres 8.4.
Get the following stack trace:
Caused by: java.lang.IllegalStateException: Illegal attempt to set lock mode on a non-SELECT query
at org.hibernate.jpa.spi.AbstractQueryImpl.setLockMode(AbstractQueryImpl.java:128)
at org.hibernate.jpa.spi.AbstractEntityManagerImpl.applySavedSettings(AbstractEntityManagerImpl.java:858)
at org.hibernate.jpa.spi.AbstractEntityManagerImpl.wrapAsJpaQuery(AbstractEntityManagerImpl.java:812)
at org.hibernate.jpa.spi.AbstractEntityManagerImpl.createNamedJpqlQuery(AbstractEntityManagerImpl.java:806)
at org.hibernate.jpa.spi.AbstractEntityManagerImpl.buildQueryFromName(AbstractEntityManagerImpl.java:785)
at org.hibernate.jpa.spi.AbstractEntityManagerImpl.createNamedQuery(AbstractEntityManagerImpl.java:770)
at com.sun.enterprise.container.common.impl.EntityManagerWrapper.createNamedQuery(EntityManagerWrapper.java:522)
at no.evote.service.impl.TestServiceImpl.deleteTasks(TestServiceImpl.java:140)
Source code can be found here: https://sourcecode.valg.no/websvn/listing.php?repname=Admin
(we will soon move to github..)
It is unfortunately difficult to run our code in a "new" environment - we work on it.
What basically happens is that we work on upgrading from glassfish 3.1.2 to glassfish 4, and from hibernate 3.5.1 to hibernate 4.3.0.CR1.
We do some manual cleaning after running a test called ElectionEventServiceTest (found in admin-backend). A method in TestServiceImpl which does the following is called:
@Override
public void deleteTasks(final UserData userData, final Long electionEventPk) {
Query query = getEm().createNamedQuery("Task.deleteElectionEventPk").setParameter("electionEventPk", electionEventPk);
query.executeUpdate();
}
where
@NamedQuery(name = "Task.deleteElectionEventPk", query = "delete from Task t where t.electionEvent.pk = :electionEventPk"),
(Task in admin-common).
The problem can be fixed by checking if the non-select query actually just tries to set lock mode to NONE which to me seems reasonable:
My local version of AbstractQueryImpl works fine..
AbstractQueryImpl:
public TypedQuery<X> setLockMode(javax.persistence.LockModeType lockModeType) {
checkOpen( true );
if ( isNativeSqlQuery() ) {
throw new IllegalStateException( "Illegal attempt to set lock mode on a native SQL query" );
}
if ( ! LockModeType.NONE.equals(lockModeType)) {
if ( ! isSelectQuery() ) {
throw new IllegalStateException( "Illegal attempt to set lock mode on a non-SELECT query" );
}
}
if ( ! canApplyAliasSpecificLockModeHints() ) {
throw new IllegalStateException( "Not a JPAQL/Criteria query" );
}
this.jpaLockMode = lockModeType;
internalApplyLockMode( lockModeType );
return this;
}