Miscellaneous bugs in unit tests when using non-default dialects

Description

There are some unit tests that are failing on non-default dialects due to things like:

  • DDL containing reserved words (e.g. "User", "key");

  • tests that use ID generators not available in all dialects;

  • column in primary key that is nullable (fails on DB22).

Tests:

org.hibernate.jpa.test.criteria.enumcollection.EnumIsMemberTest.testQueryEnumCollection
org.hibernate.test.type.converter.ElementCollectionTests.testSimpleConvertUsage
org.hibernate.test.annotations.indexcoll.IndexedCollectionTest.testEmbeddableWithEntityKey
org.hibernate.jpa.test.graphs.EntityGraphUsingFetchGraphTest.fetchAttributeNodeFromSubgraph
org.hibernate.jpa.test.graphs.EntityGraphUsingFetchGraphTest.fetchSubGraphFromSubgraph
org.hibernate.jpa.test.graphs.EntityGraphUsingFetchGraphTest.fetchUsingHql

Environment

None

Activity

Show:
Gail Badner
May 14, 2015, 9:35 PM

Closing to prepare for Hibernate ORM 4.3.10.Final release.

Gail Badner
May 12, 2015, 9:23 PM

Fixed in master and 4.3. I'll create a new jira issue for other testsuite fixes.

Gail Badner
May 1, 2015, 6:45 PM

Since it should apply to Hibernate Entity Manager as well, I've backed out of the change to org.hibernate.jpa.test.criteria.enumcollection.EnumIsMemberTest on master.

Gail Badner
May 1, 2015, 12:26 AM

This appears to be a bug in master. I've created HHH-9768.

I backed out of the change for org.hibernate.test.type.converter.ElementCollectionTests.testSimpleConvertUsage on master.

This test was failing because the table name was an ANSI SQL reserved word: org.hibernate.jpa.test.criteria.enumcollection.EnumIsMemberTest.testQueryEnumCollect

@steve, does this auto-quoting apply to hibernate-entitymanger?

Steve Ebersole
April 22, 2015, 6:16 PM

Gail, if you are going to assign this to a version (5.0) for fixing as I am actively trying to get that version ready for release, then you should also assign it to yourself to do that fixing.

I see 2 commits in regards to this already. What else still needs to be done here?

Also, the first point (DDL containing reserved words) should no longer be an issue on master (5.0). If it is, I consider that a bug in 5.0. Where do you see that happening on master?

Fixed

Assignee

Gail Badner

Reporter

Gail Badner

Fix versions

Labels

None

backPortable

None

Suitable for new contributors

None

Requires Release Note

None

Pull Request

None

backportDecision

None

Components

Priority

Minor