Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Use Jandex instead of hibernate-commons-annotations for annotation discovery

Description

This is optional but nice to have, especially if we move to Jandex for annotations scanning.

Activity

Show:

Sanne GrinoveroJune 23, 2014 at 9:01 PM

ah interesting! that my change things. I started a thread on mailing list on this too (I did before seeing your reply)

Hardy FerentschikJune 23, 2014 at 7:54 PM

I don't think it is hard to remove it completely. I have some (now unfortunately rather outdated) branch for that. I am hoping to be able to dig it out.

Sanne GrinoveroJune 23, 2014 at 7:41 PM
Edited

I think we should re-interpret this issue as "Remove references to hibernate-commons-annotations from public API", WDYT?

We can then opt to keep it as an implementation detail for the time being, and play with better solutions in the near future.

Corollary question: how can we verify the "hiding" is complete? Checkstyle in tests to violate on import statement? Might not be good enough, but is a start.

Hardy FerentschikMay 28, 2014 at 6:05 PM

Ok. So you propose a first phase to rewrite a custom metadata handling, and then switch to Jandex only when ORM is ready for it?

Kind of. Jandex is about annotations. We will have to adjust the AnnotationMetadataProvider. We might just end up with a JandexMetadataProvider, especially since with Jandex we can optimize some of the annotation processing we currently do.

The switch for the programmatic configuration is unrelated and as said in this case it is useless to work with annotations (real one, proxies or Jandex backed ones). It is a first step, just unrelated.

Sanne GrinoveroMay 28, 2014 at 5:41 PM

Ok. So you propose a first phase to rewrite a custom metadata handling, and then switch to Jandex only when ORM is ready for it?

Details

Assignee

Reporter

Components

Priority

Created October 15, 2012 at 7:24 PM
Updated September 25, 2023 at 2:48 PM