Readability of @Latitude and @Longitude

Description

Thanks for getting rid of the Coordinates interface, the annotated coordinates are much appreciated.

What about using the annotions value instead of spatial name for the spatial attribute? It probably would improve readability.

Activity

Show:

Sanne Grinovero November 27, 2012 at 8:10 PM

do you agree with the proposed "of" ? the patch looks otherwise ready to go, I'd integrate it.

Emmanuel Bernard October 19, 2012 at 6:29 PM

I remember now, we use 'on' in a few places.

Sanne Grinovero October 19, 2012 at 6:08 PM
Edited

Funny how easily one forgets that "for" is a reserved word.

Ouch.

of is not wrong, but doesn't sound as great as for. What do you all think of forSpatial ? It's more verbose but it better points out the purpose IMHO. Otherwise I'm ok with of , or to consider the default value.

Michael Simons October 19, 2012 at 4:13 PM
Edited

Funny how easily one forgets that "for" is a reserved word.

If my english is not too rusty, "latitude of home / work / whatsoever" would be correct as well.

The javadoc should really be fixed, it's not understandable that way.

Sanne Grinovero October 19, 2012 at 4:03 PM

And please let me know if you signed the CLA, otherwise it takes several days for me to receive notification for it after all the process.

Fixed

Details

Assignee

Reporter

Components

Fix versions

Priority

Created October 19, 2012 at 11:13 AM
Updated May 8, 2013 at 9:04 AM
Resolved December 12, 2012 at 4:15 PM