Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Support @Inject in ClassBridges and FieldBridge instances

Description

I saw on a recent post that Bean Validation supports @Inject natively. This would be nice for Hibernate Search Field/ClassBridge instances as well. I have been using @Configurable with @Inject in ClassBridge using Spring for a while now. It requires some Aspectj post build magic that I've never gotten to work in development (Eclipse/Tomcat). A more native approach would be great.

Activity

Show:

Stefan ProellMarch 10, 2017 at 12:25 PM

One example would be an EnumBridge, which uses a I18n Service for the translation. Users search for a particular term and I would like to put this term into the Index and map it to my internal representation with the enum. So I translate back and forth with the EnumBridge, which uses the service.

@Configurable public class HibernateSearchEnumBridgeExample extends EnumBridge { private I18nMessageService i18nMessageService; @Autowired @Required public void setI18nMessageService(I18nMessageService service) { this.i18nMessageService = service; } @Override public String objectToString(Object object) { return i18nMessageService.getMessageForEnum(object); }

Sanne GrinoveroMarch 10, 2017 at 12:05 PM

Very interesting feedback, thanks for reviving this issue!

I am concerned about boot order of components. Do you have an example of what kind of things you're all looking to inject?

Casey LinkMarch 10, 2017 at 11:38 AM

We also had quite the problem getting this working in our spring boot application due to hibernate+session factory auto configuration being started before the spring configurer aspect bean.

We worked around it by extending the HibernateJpaAutoConfiguration and declaring an explicit dependency on AnnotationBeanConfigurerAspect.

@Configuration public class HibernateSearchConfig extends HibernateJpaAutoConfiguration { public HibernateSearchConfig(DataSource dataSource, JpaProperties jpaProperties, // we need this to enforce that AnnotationBeanConfigurerAspect // is created // before the session factory gets set up AnnotationBeanConfigurerAspect beanConfigurerAspect, ObjectProvider<JtaTransactionManager> jtaTransactionManager, ObjectProvider<TransactionManagerCustomizers> transactionManagerCustomizers) { super(dataSource, jpaProperties, jtaTransactionManager, transactionManagerCustomizers); } }

Stefan ProellMarch 10, 2017 at 10:17 AM

Agreed. This would be a nice feature and allow injecting beans without having to take care of AspectJ weaving and bean loading precedence. This would be useful when the Bridge requires a different @Service to be available. Currently this easily causes NPEs if not taken care of explicitly.

Hardy FerentschikJanuary 25, 2016 at 8:24 AM

I think the rub here is that ClassBridge instances are created when the metadata is built (at startup). I think it wold help if the creation of the bridges would be delayed until first use where it would be instantiated and then cached. This would of course require a fair bit of refactoring.

Fixed

Details

Assignee

Reporter

Components

Fix versions

Priority

Created May 6, 2013 at 7:32 PM
Updated June 13, 2017 at 10:38 AM
Resolved May 17, 2017 at 12:23 PM

Flag notifications