We're updating the issue view to help you get more done. 

Checkstyle Improvement

Description

Checkstyle doesn't seem to catch some violations, like:

https://github.com/hibernate/hibernate-search/pull/419/files#L17L255

1 2 - setSpatialParameters( Point.fromDegrees( latitude, longitude ), fieldName ); + setSpatialParameters( Point.fromDegrees( latitude, longitude ), fieldName );

and

1 2 - for (Object o : resultList) { + for ( Object o : resultList ) {

and

1 2 - throw new RuntimeException( e ); + throw new RuntimeException( e );

In OGM checkstyle skipped the test submodules at some point. I solved the problem upgrading the version. I write this down as a reminder of something that should be checked.

UselessShardingStrategy seems to be a good example of violations that should be found.

Environment

None

Status

Assignee

Davide D'Alto

Reporter

Davide D'Alto

Labels

None

Suitable for new contributors

None

Pull Request

None

Feedback Requested

None

Components

Fix versions

Priority

Major