Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects versions: None
    • Fix versions: 4.4.0.Alpha1
    • Components: build
    • Labels:
      None

      Description

      Checkstyle doesn't seem to catch some violations, like:

      https://github.com/hibernate/hibernate-search/pull/419/files#L17L255

      -    setSpatialParameters(  Point.fromDegrees( latitude, longitude ), fieldName );
      +    setSpatialParameters( Point.fromDegrees( latitude, longitude ), fieldName ); 
      

      and

      -    for (Object o : resultList) { 
      +    for ( Object o : resultList ) { 
      

      and

      -      throw new RuntimeException(  e );
      +      throw new RuntimeException( e ); 
      

      In OGM checkstyle skipped the test submodules at some point. I solved the problem upgrading the version. I write this down as a reminder of something that should be checked.

      UselessShardingStrategy seems to be a good example of violations that should be found.

        Attachments

          Activity

            People

            • Assignee:
              davided Davide D'Alto
              Reporter:
              davided Davide D'Alto
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: