Selected Facet object not equal to computed Facet object
Description
Activity
Show:
Hardy Ferentschik June 7, 2013 at 11:01 AM
For all I can say now it was just oversight and a not thought through equals implementation.
Emmanuel Bernard June 4, 2013 at 10:19 PM
In particular, feedback would be nice i.e. why count was part of Facet's equality.
Note that this is making the TicketMonster demo more complicated so if we could fix this for 4.3 that'd be nice.
Emmanuel Bernard June 4, 2013 at 10:18 PM
Fixed
Details
Details
Assignee
Emmanuel BernardReporter
Emmanuel BernardComponents
Fix versions
Affects versions
Priority
MajorCreated June 4, 2013 at 8:15 PM
Updated June 7, 2013 at 10:51 PM
Resolved June 7, 2013 at 11:00 AM
The following pseudo code scenario is expected to work but fails
This is due to the fact that facet objects are different (between selected ones and recomputed ones) and that equals takes the count into account.
There are two possible fixes:
1. replace selectedFacet with recomputed ones
2. not take count as part of Facet's equality
I think 1. would be impractical especially since Facet reference can float around. So removing count from the equality seems best. However I don't fully understand why Facet.count was part of it in the first place