Specify session factory type more precisely in MassIndexerFactory#createMassIndexer()

Description

The method MassIndexerFactory#createMassIndexer() currently has a parameter of type SessionFactory. In the implementations DefaultMassIndexerFactory and OgmMassIndexerFactory this is always narrowed down to SessionFactoryImplementor, though.

As no other SF type is thus working anyways, this requirement should be made explicit by changing the parameter type. Note that this will break existing implementations of the interface (if there are any besides the two named ones).

Environment

None

Activity

Show:
Sanne Grinovero
October 7, 2013, 1:30 PM

If you send a pull request for today I'm ok in including this in 4.4

Gunnar Morling
October 7, 2013, 1:37 PM

I can do that, but given that it will break existing impls, shouldn't it go into 5? Or is it that unlikely that there are any other impls so we can take that risk?

Sanne Grinovero
October 7, 2013, 1:53 PM

This was just created for OGM recently, and we already broke the SPI contract twice during 4.4 development.

Gunnar Morling
October 7, 2013, 1:55 PM

Ok, sounds reasonable. I'll file a PR later.

Gunnar Morling
October 7, 2013, 3:27 PM

Assignee

Gunnar Morling

Reporter

Gunnar Morling

Labels

None

Suitable for new contributors

None

Pull Request

None

Feedback Requested

None

Components

Fix versions

Affects versions

Priority

Major
Configure