Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Specify session factory type more precisely in MassIndexerFactory#createMassIndexer()

Description

The method MassIndexerFactory#createMassIndexer() currently has a parameter of type SessionFactory. In the implementations DefaultMassIndexerFactory and OgmMassIndexerFactory this is always narrowed down to SessionFactoryImplementor, though.

As no other SF type is thus working anyways, this requirement should be made explicit by changing the parameter type. Note that this will break existing implementations of the interface (if there are any besides the two named ones).

Activity

Gunnar MorlingOctober 7, 2013 at 3:27 PM

Gunnar MorlingOctober 7, 2013 at 1:55 PM

Ok, sounds reasonable. I'll file a PR later.

Sanne GrinoveroOctober 7, 2013 at 1:53 PM

This was just created for OGM recently, and we already broke the SPI contract twice during 4.4 development.

Gunnar MorlingOctober 7, 2013 at 1:37 PM

I can do that, but given that it will break existing impls, shouldn't it go into 5? Or is it that unlikely that there are any other impls so we can take that risk?

Sanne GrinoveroOctober 7, 2013 at 1:30 PM

If you send a pull request for today I'm ok in including this in 4.4

Fixed

Details

Assignee

Reporter

Components

Fix versions

Priority

Created October 7, 2013 at 1:27 PM
Updated October 8, 2013 at 1:03 PM
Resolved October 7, 2013 at 4:02 PM