Testsuite failing on Windows: temporary directory for indexes is illegal
Description
Activity
![](https://secure.gravatar.com/avatar/57637a2eb871b34eba14e700c78c6a5d?d=https%3A%2F%2Favatar-management--avatars.us-west-2.prod.public.atl-paas.net%2Finitials%2FSG-6.png)
Sanne Grinovero July 18, 2014 at 8:17 AM
![](https://secure.gravatar.com/avatar/12df4da7e3351be801bc16b66caf8038?d=https%3A%2F%2Favatar-management--avatars.us-west-2.prod.public.atl-paas.net%2Finitials%2FHF-0.png)
Hardy Ferentschik June 28, 2014 at 9:59 AM
I fixed the test failures on here - https://github.com/hferentschik/hibernate-search/commit/a5ab21399ede09f8b9d84dc7f7c0c5076bbf725c. I think I will try to make sure, however, that this problem cannot occur anymore.
![](https://secure.gravatar.com/avatar/57637a2eb871b34eba14e700c78c6a5d?d=https%3A%2F%2Favatar-management--avatars.us-west-2.prod.public.atl-paas.net%2Finitials%2FSG-6.png)
Sanne Grinovero June 26, 2014 at 3:47 PM
You can do as you prefer, I'm sad though that this obviously will delay more interesting things like the Spatial API fixes.
![](https://secure.gravatar.com/avatar/12df4da7e3351be801bc16b66caf8038?d=https%3A%2F%2Favatar-management--avatars.us-west-2.prod.public.atl-paas.net%2Finitials%2FHF-0.png)
Hardy Ferentschik June 26, 2014 at 3:33 PM
I'm not too interested in the details of the problem this time
Why not? I am. I can take this issue and have a look.
and I feel we're stubborn in not using the /tmp directories like everyone should.
Nothing to do with stubbornness.
can't run multiple testuistes at once
Not sure what you mean there
easy to find on need, and I don't refer to us (anything will be easy for us as we learn) but to the occasional contributor, using /tmp is the least surprising thing
that's not true at all. The easiest and most natural place is in the build directory. That's where everyone with some Maven experience looks first. You do a 'mvn clean', and you know all is gone. You never know whether some old indexes in tmp are related to an old build. Also it is not necessarily trivial to find the tmp directory. Is it /tmp or /var/tmp or whatever.
can't use proven methods - like the JUnit helpers and relatest TestRule
our method is proven as well, unless you show me how the actual approach is broken.
![](https://secure.gravatar.com/avatar/57637a2eb871b34eba14e700c78c6a5d?d=https%3A%2F%2Favatar-management--avatars.us-west-2.prod.public.atl-paas.net%2Finitials%2FSG-6.png)
Sanne Grinovero June 26, 2014 at 1:28 PM
I'm not too interested in the details of the problem this time, but this is something that keeps coming back, and I feel we're stubborn in not using the /tmp directories like everyone should.
We don't have any benefit from avoiding it right?
There are many limitations of not using tmp:
can't run multiple testuistes at once
my /tmp is tuned for temporary, my partitions dedicated to source code I prefer using for reliable stuff
easy to find on need, and I don't refer to us (anything will be easy for us as we learn) but to the occasional contributor, using /tmp is the least surprising thing
can't use proven methods - like the JUnit helpers and relatest TestRule
And I see no benefit of insisting to keep it in the source directory?
Assignee
![](https://secure.gravatar.com/avatar/12df4da7e3351be801bc16b66caf8038?d=https%3A%2F%2Favatar-management--avatars.us-west-2.prod.public.atl-paas.net%2Finitials%2FHF-0.png)
Reporter
![](https://secure.gravatar.com/avatar/57637a2eb871b34eba14e700c78c6a5d?d=https%3A%2F%2Favatar-management--avatars.us-west-2.prod.public.atl-paas.net%2Finitials%2FSG-6.png)
Our helpers to identify the root of target aren't consistent on Windows, where yet again an illegal path is generated.
I'm switching to KISS model using the proven support in JUnit for temporary files.