Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Missing types in NumericFieldUtils#requiresNumericRangeQuery

Description

This is a followup of https://github.com/hibernate/hibernate-search/pull/1046 .

Note that the logic of NumericFieldUtils#requiresNumericRangeQuery is wrong in the general case as a type might be numeric or string depending on the backend used (see Date for the Elasticsearch backend for instance).

It is used as a fallback when we don't have a DocumentFieldMetadata. It's documented as being used in the Infinispan case (see ConnectedMultiFieldsRangeQueryBuilder#createQuery) but it's currently also used for bridge defined fields which are not registered as DocumentFieldMetadata. In this latter case, we currently only support string and numerics so it won't be an issue.

Activity

Show:

Sanne GrinoveroApril 28, 2016 at 2:42 PM

That's not a problem. As soon as someone merges it, he should mark this resolved and if needed adjust the JIRA fields (the "Fix Version" 5.6.0.Beta2)

Guillaume SmetApril 28, 2016 at 2:38 PM

in fact, there is a PR open for a while now so I think we should keep this in 5.6.0.Beta1. It's basically a no brainer and we should be able to merge it easily.

Fixed

Details

Assignee

Reporter

Components

Fix versions

Affects versions

Priority

Created April 11, 2016 at 8:31 AM
Updated May 21, 2016 at 6:43 PM
Resolved May 11, 2016 at 1:53 PM