JGroupsDynamicMasterElectionTest fails on Windows

Description

This test started to fail recently with the following error:

masterElection(org.hibernate.search.test.jgroups.common.JGroupsDynamicMasterElectionTest) Time elapsed: 1.857 sec <<< ERROR! java.nio.file.AccessDeniedException: C:\DOCUME~1\hudson.MSDOMAIN\LOCALS~1\Temp\hsearch-tests-3365087708292725535\indextemp-JGroupsDynamicMasterElectionTest\b4506653\org.hibernate.search.test.jgroups.master.TShirt\_0.cfs at sun.nio.fs.WindowsException.translateToIOException(WindowsException.java:83) at sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:97) at sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:102) at sun.nio.fs.WindowsFileSystemProvider.implDelete(WindowsFileSystemProvider.java:269) at sun.nio.fs.AbstractFileSystemProvider.delete(AbstractFileSystemProvider.java:103) at java.nio.file.Files.delete(Files.java:1126) at org.hibernate.search.util.impl.FileHelper.deleteOrFail(FileHelper.java:251) at org.hibernate.search.util.impl.FileHelper.delete(FileHelper.java:237) at org.hibernate.search.util.impl.FileHelper.access$000(FileHelper.java:33) at org.hibernate.search.util.impl.FileHelper$1.visitFile(FileHelper.java:220) at org.hibernate.search.util.impl.FileHelper$1.visitFile(FileHelper.java:217) at java.nio.file.Files.walkFileTree(Files.java:2670) at java.nio.file.Files.walkFileTree(Files.java:2742) at org.hibernate.search.util.impl.FileHelper.deleteRecursive(FileHelper.java:217) at org.hibernate.search.util.impl.FileHelper.delete(FileHelper.java:193) at org.hibernate.search.test.DefaultTestResourceManager.ensureIndexesAreEmpty(DefaultTestResourceManager.java:162) at org.hibernate.search.test.DefaultTestResourceManager.defaultTearDown(DefaultTestResourceManager.java:190) at org.hibernate.search.test.jgroups.common.DynamicMasterSlaveSearchTestCase.tearDown(DynamicMasterSlaveSearchTestCase.java:70)

I believe it's possible that some resources have not been closed correctly, we need to investigate that.

This happened in the internal QA lab:

Activity

Yoann RodièreJune 6, 2017 at 4:03 PM

You're right, it's something else. There's something particular in this test: multiple search factories share the same index files. I think I know what's wrong, I'll test and send a PR.

Sanne GrinoveroJune 6, 2017 at 3:54 PM

In the case of https://hibernate.atlassian.net/browse/HSEARCH-2690#icft=HSEARCH-2690 it was actually possible ( and legit ) that the files were not closed yet. In this case, we need to ensure the files have been closed correctly: I suspect it was leaking some resource. More likely solved by your https://hibernate.atlassian.net/browse/HSEARCH-2749#icft=HSEARCH-2749 ?

Yoann RodièreJune 6, 2017 at 3:45 PM

Maybe it's linked to HSEARCH-2690, which also happened on Windows only... ? Having a look.

Fixed

Details

Assignee

Reporter

Components

Fix versions

Priority

Created May 24, 2017 at 11:45 AM
Updated June 13, 2017 at 10:38 AM
Resolved June 9, 2017 at 9:11 AM

Flag notifications