Remove (deprecated) methods using Class<?> as indexed type identifier in the engine SPIs
Description
causes
follows up on
relates to
Activity
Yoann Rodière April 10, 2018 at 2:46 PM
> The "DeleteByQueryWork.java" class changed from accepting class to requiring IndexedTypeIdentifier now as first parameter.
Oh my, and this is API. I really thought this was SPI... Well, looks like I messed up.
Thanks for the heads-up, I'll update the migration guide and discuss the API break with the team.
> Do I use it wrong?
Well it depends.
If you are using the ORM integration you generally shouldn't need to use it unless you have very specific needs.
If you are not using the ORM integration, then it's your only way to delete a document, so you're using it right.
Carsten Hammer April 10, 2018 at 2:16 PM
The "DeleteByQueryWork.java" class changed from accepting class to requiring IndexedTypeIdentifier now as first parameter. Do I use it wrong?
Yoann Rodière April 10, 2018 at 2:10 PM
@Carsten Hammer Thanks for your suggestion. PojoIndexedTypeIdentifier is an internal type though, and you shouldn't need to use it. Could you please tell use where you had to use it? Maybe we should move it to API or SPI...
Carsten Hammer April 10, 2018 at 1:44 PM
It might be useful to mention the use of PojoIndexedTypeIdentifier.convertFromLegacy() on the page http://hibernate.org/search/documentation/migrate/5.8/ where changes regarding IndexedTypeIdentifier are listed.
Details
Assignee
Sanne GrinoveroSanne GrinoveroReporter
Yoann RodièreYoann RodièreComponents
Fix versions
Priority
Major
Details
Details
Assignee
Reporter
Components
Fix versions
Priority
Major
To be done in 5.8.0.Beta4/5.8.0.CR1 if Infinispan has been able to keep up with changes in HSEARCH-1404. It all depends on whether Infinispan will be able to cope with these changes or not. If they don't, we'll just postpone this ticket to 6.