Allow non-String values in environment configuration

Description

Hi there,

while trying to use

1 properties.put(Environment.INDEX_UNINVERTING_ALLOWED, true);

I have discovered that

1 org.hibernate.search.util.configuration.impl.ConfigurationParseHelper#getBooleanValue

uses

1 Properties.getProperty

which returns null when the property value is not a string (for whatever reason...).

In my case, this has the effect that using a boolean "true" INDEX_UNINVERTING_ALLOWED is not recognized and an exception is thrown instead as this is now the default. Using a string based

1 properties.put(Environment.INDEX_UNINVERTING_ALLOWED,"true");

IMHO, this is a pitfall that could be easily avoided by also allowing boolean values.

Environment

None

Status

Assignee

Yoann Rodière

Reporter

Niko Wittenbeck

Labels

None

Suitable for new contributors

Yes, likely

Feedback Requested

None

Components

Fix versions

Affects versions

5.5.8.Final
5.7.3.Final
5.6.4.Final
5.10.0.Final
5.9.1.Final

Priority

Minor
Configure