Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

SearchSession#isOpen() in the javabean mapper

Description

Session activity information is missing. This is very important if the previously opened session was opened by another code fragment in the same transaction. Elsewhere, the same session is accessed without knowing if a session shutdown was programmatically performed before.

The fix would be to add a "boolean active()" field to the "SearchSession" api.


package org.hibernate.search.mapper.javabean.session; public interface SearchSession extends AutoCloseable { /**Get the active session state . *@return A active session state. */ boolean active(); }

Activity

Show:

Yoann RodièreApril 20, 2021 at 11:12 AM

This is not a bug, it’s a feature request. I changed the issue type accordingly.

Maybe name the new method isOpen(), to be consistent with the wording of the close() method? That would also be more consistent with EntityManager#isOpen.

But sure, feel free to submit a PR.

Waldemar KłaczyńskiApril 20, 2021 at 10:46 AM
Edited

It is useful if in several places of the code it is checked whether the session has already been used in the transaction and has not been closed:


String key = SearchTransactionUtil.getScopedName(areaClassLoader, "SearchSession", unit, owner, areaName, owner); if (key != null && TransactionHelper.isInTx()) { session = SearchTransactionUtil.get(key); } if (session == null || !session.active()) { SearchMapping mapping = createMapping(unit, type, owner); session = mapping.createSessionWithOptions(). ... } return session;
Fixed

Details

Assignee

Reporter

Components

Fix versions

Priority

Created April 20, 2021 at 10:32 AM
Updated September 10, 2021 at 7:24 AM
Resolved April 20, 2021 at 2:36 PM

Flag notifications