Consistently refer to the predicate inside a "nested" predicate as the "inner" predicate

Description

A "nested" predicate is called that way because it deals with "nested" documents/fields.

It also happens to contain another predicate, and we've always been weird about how to name that predicate. Sometimes we call it "nested", which is obviously confusing, since both the outer predicate and the inner predicate are called "nested". I think sometimes we call it some other ways, too.

Let's be consistent and always call the predicate inside a nested predicate the "inner" predicate.

This means:

  • Changing the wording in the documentation

  • Renaming NestedPredicateNestStep to NestedPredicateInnerStep, and NestedPredicateInnerStep#nest(...) to NestedPredicateInnerStep#inner(...). Make sure to preserve backwards compatibility by keeping the deprecated "nest" interface/methods.

  • Going through all the code related to nested predicates to always use the qualifier "inner" (and not "nested") for the inner predicate.

Activity

Show:

Yoann Rodière June 13, 2022 at 12:45 PM

This is no longer relevant now that we changed how nested predicates are defined in HSEARCH-4499.

Out of Date

Details

Assignee

Reporter

Components

Priority

Created October 21, 2021 at 7:24 AM
Updated June 13, 2022 at 12:45 PM
Resolved June 13, 2022 at 12:45 PM