Fixed
Details
Assignee
Guillaume SmetGuillaume SmetReporter
Guillaume SmetGuillaume SmetBug Testcase Reminder (view)
Bug reports should generally be accompanied by a test case!
Bug Testcase Reminder (edit)
Bug reports should generally be accompanied by a test case!
Participants
Guillaume SmetComponents
Fix versions
Priority
Minor
Details
Details
Assignee
Guillaume Smet
Guillaume SmetReporter
Guillaume Smet
Guillaume SmetBug Testcase Reminder (view)
Bug reports should generally be accompanied by a test case!
Bug Testcase Reminder (edit)
Bug reports should generally be accompanied by a test case!
Participants
Guillaume Smet
Components
Fix versions
Priority
Created June 12, 2017 at 9:48 AM
Updated July 5, 2017 at 3:24 PM
Resolved July 5, 2017 at 1:17 PM
We should get rid of
GetConstraintValidatorsFromServiceLoader
and useGetInstancesFromServiceLoader
instead.Moreover, I think we can safely remove
serviceLoaderBasedConstraintMappingContributor
fromConfigurationImpl
.We can instantiate it in
ValidatorFactoryImpl
: it will be safer (we will need to pass theexternalClassLoader
to it and thus it will be possible to callgetServiceLoaderBasedConstraintMappingContributor()
before the call toexternalClassLoader(...)
which would be wrong) and we don't need to keep it around, once the initialization is done.