E-mail validator does not allow IDN ascii domain labels

Description

implemented support for IDN in the EmailValidator, but in commit db8c4f0 in january 2017 the implementation was changed (spesifically the domain validation was moved to a new class). This new implementation of domain validation does not allow -- in domain labels, and as such, the ascii representation of IDN domain labels fails to validate, even though most email programs will accept it, since the domain is in fact a valid ascii domain name.

One quick example is for instance nothing@xn--fken-gra.no (the domain isn't registered, but should serve for this example.

Environment

None

Activity

Show:

Aleksander Blomskøld November 15, 2017 at 1:24 PM

Awesome!

Guillaume Smet November 15, 2017 at 9:59 AM

Hi ,

It's planned for today!

Aleksander Blomskøld November 15, 2017 at 9:53 AM

Hi guys. Great to see this issue being resolved so quickly. Do you have any estimate on when you'll ship your next release?

Andreas Marienborg November 3, 2017 at 3:37 PM

Amazing speed Thanks for looking into it so quickly

Guillaume Smet November 3, 2017 at 12:32 PM

I pushed a PR here: https://github.com/hibernate/hibernate-validator/pull/881

Comments welcome!

Fixed

Assignee

Guillaume Smet

Reporter

Bug Testcase Reminder (view)

Bug reports should generally be accompanied by a test case!

Bug Testcase Reminder (edit)

Bug reports should generally be accompanied by a test case!

Participants

Aleksander Blomskøld
Andreas Marienborg
Guillaume Smet

Components

Fix versions

Affects versions

Priority

Created November 3, 2017 at 9:49 AM
Updated November 15, 2017 at 4:15 PM
Resolved November 7, 2017 at 6:36 PM
Loading...