Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Unable to specify constraints at more than 1 nested parameter of a typed container

Description

I am attempting to build a nested constraint mapping for a container using the containerElementType method and I noticed that I am only able to create constraints at 1 nested parameter of a typed container.

Tracing through the code I think the hashmap put at line 137 of CascadableConstraintMappingContextImplBase is allowing only 1 nested constraint value to be kept because it is keying on index which is 1 in both cases.

I was able to reproduce the issue with a small modification to the canDeclareDeeplyNestedContainerElementConstraintsForFieldProgrammatically method of ProgrammaticContainerElementConstraintsForFieldTest that adds a size constraint to the list of fish. I noticed that if i flip the order i declare the constraints it affects which violation makes it through and which is thrown out.

Here is a test case to reproduce this issue. It leverages the FishTank type from ProgrammaticContainerElementConstraintsForFieldTest

Environment

java 8 66 eclipse 4.6.1 windows 7

Activity

Show:

Guillaume SmetMay 10, 2018 at 7:15 PM

Thanks for the confirmation, very much appreciated.

Nathan James DeckardMay 10, 2018 at 6:54 PM

and I have built 6.0.10-SNAPSHOT and applied it to my project and I can confirm that you have fixed the bug. I'll upgrade immediately when this is released next week. Thanks so much!

Guillaume SmetMay 9, 2018 at 7:54 PM

the issue is fixed. Expect a release early next week (Tuesday or Wednesday).

Thanks for the very clear report.

It would be nice if you could test our 6.0 branch to be sure everything works for you. A simple mvn clean install -DskipTests will build the artifacts for you.

Nathan James DeckardMay 7, 2018 at 8:38 PM

Thanks. I just renamed the headline to a better name.

Guillaume SmetMay 7, 2018 at 8:36 PM

Thanks for the test case, we'll look into it soon.

Fixed

Details

Assignee

Reporter

Bug Testcase Reminder (view)

Bug reports should generally be accompanied by a test case!

Bug Testcase Reminder (edit)

Bug reports should generally be accompanied by a test case!

Participants

Guillaume Smet
Marko Bekhta
Nathan James Deckard

Pull Request

https://github.com/hibernate/hibernate-validator/pull/959

Components

Fix versions

Affects versions

Priority

Created May 7, 2018 at 8:29 PM
Updated May 15, 2018 at 11:06 AM
Resolved May 9, 2018 at 7:54 PM