Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

fail-fast doesn't work on composite constraints

Description

I have a composite constraint @Foo that's validated by FooValidator. @Foo's marked with @Bar, which is validated by BarValidator.

When I validate a bean whose property is marked as @Foo, and BarValidator fails, FooValidator is still being run. This prevents me from assuming that BarValidator has passed, which defeats the purpose of marking @Foo with @Bar because FooValidator now has to repeat the work of BarValidator.

The culprit as best I can tell is line 133 of ConstraintTree, which doesn't check the fail-fast property before running the validator of the constraint itself.

Environment

None

Activity

Show:

Gunnar MorlingMarch 1, 2012 at 1:46 AM

Applied pull request

Fixed

Details

Assignee

Reporter

Bug Testcase Reminder (view)

Bug reports should generally be accompanied by a test case!

Bug Testcase Reminder (edit)

Bug reports should generally be accompanied by a test case!

Participants

Emerson Farrugia
Gunnar Morling
Hardy Ferentschik

Components

Fix versions

Affects versions

Priority

Created January 5, 2012 at 4:50 AM
Updated November 12, 2012 at 6:38 PM
Resolved March 1, 2012 at 1:46 AM