Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

ReflectionHelper leaks deployment classes in wildfly integration

Description

ReflectionHelper retains a reference to validated classes in wildfly deployments meaning they can't be undeployed.

https://github.com/hibernate/hibernate-validator/blob/master/engine/src/main/java/org/hibernate/validator/internal/util/ReflectionHelper.java?source=cc#L97

TypeResolver has an internal cache of resolved classes which are not released.

Environment

Fedora 19, Oracle 7u45, Wildfly 7952aa65e67e1d, Hibernate 4.3.0.Beta4, PostgreSQL 9.2

Activity

Show:

Gunnar MorlingDecember 4, 2013 at 8:57 AM

The default profile is fine, it includes everything required.

So if mvn clean install succeeds, all tests pass. The only speciality is the runner for the TCK test suite (module tck-runner), which runs the TCK "stand-alone"; to run the TCK on WildFly instead, append "-Dincontainer". Note that you may want to skip the DocBook translations by appending -Djdocbook.ignoreTranslations=true in case you don't have po2xml on your system.

Going to check out your PR asap.

Brent DouglasDecember 4, 2013 at 8:41 AM
Edited

Thanks, in the contributing page it says to make sure I run all the tests. Does that just mean anything attached to the default maven profile or are there extra test profiles I need to enable?

Gunnar MorlingDecember 4, 2013 at 8:18 AM

Awesome! You can find the stylesheet attached to this page, which also contains other useful info.

Brent DouglasDecember 4, 2013 at 8:14 AM
Edited

Yourkit 10. I actually have a PR ready for this but I just noticed that you guys use a different code style that the idea default one, I was just about to reformat it.

Gunnar MorlingDecember 4, 2013 at 8:04 AM

Thanks for reporting this. Just out of interest, what tooling did you use to spot this leak?

Fixed

Details

Assignee

Reporter

Bug Testcase Reminder (view)

Bug reports should generally be accompanied by a test case!

Bug Testcase Reminder (edit)

Bug reports should generally be accompanied by a test case!

Participants

Brent Douglas
Gunnar Morling

Original estimate

Time tracking

No time logged1h remaining

Components

Fix versions

Affects versions

Priority

Created December 4, 2013 at 4:58 AM
Updated January 28, 2014 at 9:51 AM
Resolved December 6, 2013 at 12:31 PM