Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Implement optional relaxation of parameter validation consistent with Section 4.5.5

Description

Section 4.5.5 of Validation Specification V 1.1 allows that "providers may implement alternative, potentially more liberal, approaches for handling constrained methods in inheritance hierarchies". By default, an implementation must throw a ConstraintDefinitionException when a parameter constraint is defined on an overriding method.
The requested feature would implement a property to allow for relaxation of this requirement in two modes. The first mode would simply relax the requirement entirely, i.e. constraints may be defined on overriding methods without limit. The second mode would allow constraints on overriding methods to re-define existing constraints on the overridden method. For example:

The second mode preserves some indication in code that a constraint violation may occur.

Environment

None

Activity

Show:

Hardy FerentschikNovember 29, 2015 at 5:04 PM

New pull request.

Hardy FerentschikMay 18, 2015 at 10:15 AM

I’ll try to carve out some time for the re-basing either this weekend or next week.

Great.

I have not looked at the code since we spoke last, any clue as to how much has changed? Particularly with specifying options?

The basic approach is still the same. My guess is that the rebase should be quite simple.

Chris BeckeyMay 15, 2015 at 6:25 PM

I’ll try to carve out some time for the re-basing either this weekend or next week.
I have not looked at the code since we spoke last, any clue as to how much has changed? Particularly with specifying options?

Thanks,
Chris Beckey
Skype: cbeckey
smtp: cbeckey@paypal.com
cell: (443)865-3482

From: "Hardy Ferentschik (JIRA)" <jira@hibernate.atlassian.net<jira@hibernate.atlassian.net>>
Date: Tuesday, May 12, 2015 at 4:34 AM
To: "Beckey, Chris(AWF)" <cbeckey@paypal.com<cbeckey@paypal.com>>
Subject: [JIRA] (HV-872) Implement optional relaxation of parameter validation consistent with Section 4.5.5

https://secure.gravatar.com/avatar/12df4da7e3351be801bc16b66caf8038?d=mm&s=48 Hardy Ferentschik<https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=hardy.ferentschik>commented on [New Feature] HV-872<https://hibernate.atlassian.net/browse/HV-872>

Re: Implement optional relaxation of parameter validation consistent with Section 4.5.5<https://hibernate.atlassian.net/browse/HV-872>

Hi Chris Beckey<https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=cbeckey>, sorry for the long radio silence. I believe the license agreement part is sorted out by now, right? Maybe you could create a updated pull request for this feature? If possible please rebase your changes on the latest master and maybe squash the commits into a single commit making sure to start the commit message with the JIRA key HV-872<https://hibernate.atlassian.net/browse/HV-872> (if you have problems with git - rebase, squash, etc - just create the pull request and we take it from there.

[Add Comment]<https://hibernate.atlassian.net/browse/HV-872#add-comment> Add Comment<https://hibernate.atlassian.net/browse/HV-872#add-comment>

This message was sent by Atlassian JIRA (v6.5-OD-03-002#65000-sha1:b8f65f8)
[Atlassian logo]

Hardy FerentschikMay 12, 2015 at 8:33 AM

Hi , sorry for the long radio silence. I believe the license agreement part is sorted out by now, right? Maybe you could create a updated pull request for this feature? If possible please rebase your changes on the latest master and maybe squash the commits into a single commit making sure to start the commit message with the JIRA key (if you have problems with git - rebase, squash, etc - just create the pull request and we take it from there.

Chris BeckeyMarch 12, 2014 at 7:41 PM

Code is available at https://github.com/hibernate/hibernate-validator/pull/308

Please let me know if you need anything else, or if this will get used.

Thanks,
Chris

Fixed

Details

Assignee

Reporter

Labels

Participants

Chris Beckey
Gunnar Morling
Hardy Ferentschik

Pull Request

https://github.com/hibernate/hibernate-validator/pull/448

Components

Fix versions

Affects versions

Priority

Created March 4, 2014 at 3:15 PM
Updated January 15, 2016 at 10:10 AM
Resolved December 23, 2015 at 2:56 PM