Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Using NaN and Infinity triggers an exception for (Decimal)Min and (Decimal)Max constraints

Description

I have the following validation rules defined in an interface:

In my tests, I also pass unexpected values such as Double.NAN or Double.POSITIVE_INFINITY.

This triggers an exception:

The exception is caused by the call to BigDecimal.valueOf(double val) in org.hibernate.validator.internal.constraintvalidators.bv.DecimalMaxValidatorForNumber, which throws an exception if val is infinite or NaN.

The issue can be reproduced using the attached project.

Environment

None

Attachments

1

Activity

Show:

Xavier SosnovskySeptember 17, 2014 at 8:28 PM

I have sent a pull request with a proposed fix: https://github.com/hibernate/hibernate-validator/pull/343. Happy to change the rules if you find them suboptimal.

Fixed

Details

Assignee

Reporter

Bug Testcase Reminder (view)

Bug reports should generally be accompanied by a test case!

Bug Testcase Reminder (edit)

Bug reports should generally be accompanied by a test case!

Participants

Xavier Sosnovsky

Components

Fix versions

Affects versions

Priority

Created September 17, 2014 at 7:59 PM
Updated October 22, 2014 at 2:50 PM
Resolved October 2, 2014 at 10:35 AM