Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

ConstraintDescriptorImpl.equals does not match Annotation Proxies

Description

Class.getAnnotations() returns a Proxy object wrapping the annotation class; these objects are cached. ConstraintDescriptorImpl uses the equals() method of the annotation, but the proxy object does not implement a equals method, so Object.equals() is used.

Under high load or low memory, the cached proxy objects get cleared and newly initialized, which breaks the equals-check and the validation gets skipped.

Annotation.annotationType() should be checked.

This bug may be related to

I'm still working on an unittest to show this behavior. At the moment we can reproduce it by hammering our Struts2 application with JMeter.

Environment

None

Attachments

1

Activity

Show:

sebastian haasOctober 15, 2014 at 11:45 AM

No need to wait for us. It worked in all our load test runs so far.
Thank you for the fast bugfix.

Hardy FerentschikOctober 14, 2014 at 2:02 PM

We will test it on a larger scale over the next few days.

Great.

It seams it's really a duplicate of bug HV-930.

Ok. I wait a few more days to see if you have any more problems. Other than that I am planning for a 5.1.3.Final asap.

Hardy FerentschikOctober 14, 2014 at 2:00 PM

Most likely a duplicate of

sebastian haasOctober 14, 2014 at 8:48 AM

Thanks. The snapshot version looks good for us - we will test it on a larger scale over the next few days. It seams it's really a duplicate of bug HV-930.
Somehow I cannot reproduce the fallback to Object.equals when comparing the annotation proxies any more. Even with the 5.1.2.Final version.
I suspect a mismatch of library and source version in my debugging environment.

Hardy FerentschikOctober 13, 2014 at 9:36 PM

Would you mind giving 5.1.3-SNAPSHOT a go. You find it in the JBoss Maven Repo - https://repository.jboss.org/nexus/content/groups/public/, in case you are not using it yet. I just changed the ConstraintLocation equals/hashCode so far.

Duplicate

Details

Assignee

Reporter

Bug Testcase Reminder (view)

Bug reports should generally be accompanied by a test case!

Bug Testcase Reminder (edit)

Bug reports should generally be accompanied by a test case!

Participants

Hardy Ferentschik
sebastian haas

Components

Fix versions

Affects versions

Priority

Created October 10, 2014 at 10:58 AM
Updated October 22, 2014 at 2:50 PM
Resolved October 22, 2014 at 11:13 AM