Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

This issue can't be edited

Because it belongs to an archived project. Jira admins can restore projects from the archive.

Avoid client side sorting for multi-get

Description

See the discussion in PR #585:

As the order of results returned from MongoDB/Neo4j is not guaranteed to be the same as the order of the requested keys, sub-optimal client-side processing of the result set is needed. This could be avoided if there was a way to obtain the results in the order of requested keys.

Environment

None

Activity

Show:

Gunnar MorlingDecember 16, 2015 at 10:13 AM

As a reminder, see the discussions in PRs #604 and #585; We could likely speed up things by consuming the result cursor into a map and then assigning values to requested keys by map look-ups. For larger number of keys - with the threshold to be defined - this should be faster than the nested looping. The idea is to use one or the other approach depending on the number of requested keys.

This all is assuming we cannot find a way to get back the results in the order we expect.

Gunnar MorlingDecember 14, 2015 at 3:56 PM

The 907 one has been merged already, but yes, if you sent another one for that improvement that'd be cool.

Davide D'AltoDecember 14, 2015 at 3:54 PM
Edited

Oops, didn't notice it was the other JIRA

Davide D'AltoDecember 14, 2015 at 3:49 PM

Ok, I'll update the pull request

Gunnar MorlingDecember 14, 2015 at 3:47 PM

Ok, as discussed with , there will be no duplicates in the key array passed to getTuples(). This means we can abort the inner loop for assigning result rows to requested keys as soon as the first (and only) matching key has been found. That'll improve perf of this a bit.

Details

Assignee

Reporter

Participants

Davide D'Alto
Gunnar Morling

Priority

Created December 14, 2015 at 11:05 AM
Updated December 16, 2015 at 10:13 AM