Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Issues

Select view

Select search mode

 
24 of 24

JoinColumn on non key field fails to populate collection

Fixed

Description

To duplicate the issue, create three tables in a database with no declared primary or foreign keys. Map entities to two of the tables. One of these entities has a primitive @Id; the other has an @EmbeddedId. Both entities contain an additional field used to join with the third table and populate a collection.

This works with the entity that has a primitive @Id but for the entity with @EmbeddedId, trying to do anything with the collection after calling the getter results in:

javax.ejb.EJBException: org.hibernate.PropertyAccessException: could not get a field value by reflection getter of jboss.example.DoesNotWorkPk.id1
at org.jboss.ejb3.tx.Ejb3TxPolicy.handleExceptionInOurTx(Ejb3TxPolicy.java:77)
....
Caused by: org.hibernate.PropertyAccessException: could not get a field value by reflection getter of jboss.example.DoesNotWorkPk.id1
at org.hibernate.property.DirectPropertyAccessor$DirectGetter.get(DirectPropertyAccessor.java:58)
....
Caused by: java.lang.IllegalArgumentException: Can not set java.lang.String field jboss.example.DoesNotWorkPk.id1 to jboss.example.DoesNotWork
at sun.reflect.UnsafeFieldAccessorImpl.throwSetIllegalArgumentException(UnsafeFieldAccessorImpl.java:146)

I've attached a sample project. The relevant files are Works.java, DoesNotWork.java, and DoesNotWorkPk.java
There's also data.sql along with the java files to populate a mysql db, but I think any DB will do.

Attachments

1
  • 06 May 2011, 07:00 PM

Details

Assignee

Reporter

Time tracking

6.12h logged

Components

Fix versions

Affects versions

Priority

Created May 6, 2011 at 7:00 PM
Updated March 7, 2014 at 10:08 PM
Resolved July 24, 2012 at 9:59 PM

Activity

Brett MeyerMarch 7, 2014 at 10:08 PM

Bulk closing tickets resolved in released versions

Strong LiuJuly 25, 2012 at 3:41 AM

you commited this to the master branch, which i think it should be ported to 4.1 branch as well

Strong LiuJuly 23, 2012 at 6:12 PM

org.hibernate.type.CollectionType#getKeyOfOwner returns entity instance as collection key instead of composite pk instance, which is expected

Strong LiuJuly 23, 2012 at 6:09 PM

I have some analysis on this issue:

when initialising an EntityKey (with this constructor public EntityKey(Serializable id, EntityPersister persister, EntityMode entityMode)), somehow, the serializable id instance is actually the Entity (with embedded id) instance itself, and identifierType get by `this.identifierType = persister.getIdentifierType();` is correct – the embedded id type.

the method org.hibernate.engine.EntityKey#generateHashCode is called during initialising time, and it then calls `identifierType.getHashCode( identifier, entityMode, factory )`

since identifierType is actually ComponentType, so, in the method getHashCode, this class will using getters to get each filed values from identifier, then there is a type mismatch happens, the identifier type here is supposed to be the embedded pk instance, which it is actually the entity class instance.

so, the https://gist.github.com/3164408 exception throws

Steve EbersoleJuly 23, 2012 at 6:05 PM
Edited

[10:47] <sebersole> have you looked at it at all? [10:47] <stliu> sebersole: yes, i looked it in the last weekend [10:48] <stliu> org.hibernate.engine.EntityKey#EntityKey [10:49] <sebersole> what about entitykey? [10:49] <stliu> in this constructor, "this.identifierType = persister.getIdentifierType();" has correct identifierType (the composite pk type) [10:49] <stliu> "this.identifier = id; ", but is the entity it self, not the instance of composite pk [10:50] <stliu> so, in the method of org.hibernate.engine.EntityKey#generateHashCode [10:50] <stliu> identifierType.getHashCode( identifier, entityMode, factory ); [10:50] <sebersole> it is a "non aggregated composite pk"? [10:50] <stliu> correct

Flag notifications