Uploaded image for project: 'Hibernate Validator'
  1. HV-1609

CDI extension should not rely on @WithAnnotations filtering

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.0.10.Final
    • Component/s: integration
    • Labels:
      None

      Description

      @WithAnnotations currently used to filter out that should not be wrapped with validation proxy is not checking for annotations on implemented interfaces and on super classes. Hence in cases like:

      @ValidateOnExecution(type = ExecutableType.ALL)
      public interface ShipmentService {
          public void findShipment(@NotNull String id);
      }
      
      public class ShipmentServiceImpl implements ShipmentService {
          @Override
          public void findShipment(String id) {
          }
      }
      

      ShipmentServiceImpl will not be proxied and no validation will be performed on its method calls. a discussion from weld-dev mailing list has some additional information (could be found here).
      Based on this we need to remove the usage of this annotation and add our own filter.

        Attachments

          Issue links

            Activity

              People

              • Assignee:
                markob Marko Bekhta
                Reporter:
                markob Marko Bekhta
                Participants:
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Stride room